Addressed Review Comments

Signed-off-by: Kunal Singh<singhk@vmware.com>

samples/vmc/helpers/sample_cli.py

@@ -35,14 +35,14 @@ optional_args = parser.add_argument_group(
         'optional arguments')
 
 required_args.add_argument(
-        '--refresh-token',
+        '--refresh_token',
         required=True,
         help='Refresh token obtained from CSP')
 required_args.add_argument(
-        '--org-id',
+        '--org_id',
         required=True,
         help='Orgization ID')
 required_args.add_argument(
-        '--sddc-id',
+        '--sddc_id',
         required=True,
         help='SDDC ID')

samples/vmc/networks_nsxt/l3_vpn_crud.py

@@ -39,7 +39,7 @@ class NSXPolicyL3VPN(object):
     """
 
     def __init__(self):
-        required_args.add_argument('--remote-endpoint-public-ip',
+        required_args.add_argument('--remote_endpoint_public_ip',
                             required=True,
                             help='L3 VPN Remote end point\'s public ip')
 

samples/vmc/networks_nsxt/security_group_create.py

@@ -36,7 +36,7 @@ Create a new NSX-T Group on MGW or CGW
 Sample Prerequisites:
     - SDDC deployed in VMware Cloud on AWS
 """
-optional_args.add_argument('--gateway-type',
+optional_args.add_argument('--gateway_type',
                     default='mgw',
                     help='Gateway type. Either mgw or cgw')
 
@@ -44,11 +44,11 @@ required_args.add_argument('--name',
                     required=True,
                     help='Name of the security group to be created')
 
-optional_args.add_argument('--ip-address',
+optional_args.add_argument('--ip_address',
                     default='172.31.0.0/24',
                     help='IP address for the expression')
 
-optional_args.add_argument('--group-id',
+optional_args.add_argument('--group_id',
                     help='ID of the group. A random ID will be used by default')
 
 args = parser.parse_args()

samples/vmc/networks_nsxt/security_group_delete.py

@@ -39,11 +39,11 @@ Sample Prerequisites:
     - SDDC deployed in VMware Cloud on AWS
     - A NSX-T security group
 """
-optional_args.add_argument('--gateway-type',
+optional_args.add_argument('--gateway_type',
                     default='mgw',
                     help='Gateway type. Either mgw or cgw')
 
-optional_args.add_argument('--group-id',
+optional_args.add_argument('--group_id',
                     help='ID of the group to be deleted')
 
 args = parser.parse_args()

samples/vmc/networks_nsxt/security_group_update.py

@@ -40,11 +40,11 @@ Sample Prerequisites:
     - SDDC deployed in VMware Cloud on AWS
     - A NSX-T security group
 """
-optional_args.add_argument('--gateway-type',
+optional_args.add_argument('--gateway_type',
                     default='mgw',
                     help='Gateway type. Either mgw or cgw')
 
-optional_args.add_argument('--group-id',
+optional_args.add_argument('--group_id',
                     help='ID of the group to be updated')
 
 required_args.add_argument('--name',

samples/vmc/orgs/organization_operations.py

@@ -41,7 +41,7 @@ class OperationsOnOrganizations(object):
         required_args = parser.add_argument_group(
             'required arguments')
         required_args.add_argument(
-            '--refresh-token',
+            '--refresh_token',
             required=True,
             help='VMware Cloud API refresh token')
 

samples/vmc/sddc/sddc_crud.py

@@ -41,12 +41,12 @@ class CreateDeleteSDDC(object):
             'optional arguments')
 
         required_args.add_argument(
-            '--refresh-token',
+            '--refresh_token',
             required=True,
             help='Refresh token obtained from CSP')
 
         required_args.add_argument(
-            '--org-id',
+            '--org_id',
             required=True,
             help='Organization identifier.')
 

samples/vmc/tasks/cancel_task.py

@@ -32,7 +32,7 @@ required_args = parser.add_argument_group(
         'required arguments')
 
 required_args.add_argument(
-        '--refresh-token',
+        '--refresh_token',
         required=True,
         help='Refresh token obtained from CSP')
 

samples/vmc/tasks/list_tasks.py

@@ -34,7 +34,7 @@ required_args = parser.add_argument_group(
         'required arguments')
 
 required_args.add_argument(
-        '--refresh-token',
+        '--refresh_token',
         required=True,
         help='Refresh token obtained from CSP')
 required_args.add_argument(

samples/vmc/tasks/list_tasks_stg.py

@@ -36,7 +36,7 @@ optional_args = parser.add_argument_group(
         'optional arguments')
 
 required_args.add_argument(
-        '--refresh-token',
+        '--refresh_token',
         required=True,
         help='Refresh token obtained from CSP')