From a9c4b6808a2a4661810f8aee2fb185f744b5a31b Mon Sep 17 00:00:00 2001 From: Kunal Singh Date: Fri, 6 Sep 2019 14:47:32 +0530 Subject: [PATCH] Addressed Review Comments Signed-off-by: Kunal Singh --- samples/vmc/helpers/sample_cli.py | 6 +++--- samples/vmc/networks_nsxt/l3_vpn_crud.py | 2 +- samples/vmc/networks_nsxt/security_group_create.py | 6 +++--- samples/vmc/networks_nsxt/security_group_delete.py | 4 ++-- samples/vmc/networks_nsxt/security_group_update.py | 4 ++-- samples/vmc/orgs/organization_operations.py | 2 +- samples/vmc/sddc/sddc_crud.py | 4 ++-- samples/vmc/tasks/cancel_task.py | 2 +- samples/vmc/tasks/list_tasks.py | 2 +- samples/vmc/tasks/list_tasks_stg.py | 2 +- 10 files changed, 17 insertions(+), 17 deletions(-) diff --git a/samples/vmc/helpers/sample_cli.py b/samples/vmc/helpers/sample_cli.py index 900c7672..a2a07f49 100644 --- a/samples/vmc/helpers/sample_cli.py +++ b/samples/vmc/helpers/sample_cli.py @@ -35,14 +35,14 @@ optional_args = parser.add_argument_group( 'optional arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='Refresh token obtained from CSP') required_args.add_argument( - '--org-id', + '--org_id', required=True, help='Orgization ID') required_args.add_argument( - '--sddc-id', + '--sddc_id', required=True, help='SDDC ID') diff --git a/samples/vmc/networks_nsxt/l3_vpn_crud.py b/samples/vmc/networks_nsxt/l3_vpn_crud.py index be967761..e1162096 100644 --- a/samples/vmc/networks_nsxt/l3_vpn_crud.py +++ b/samples/vmc/networks_nsxt/l3_vpn_crud.py @@ -39,7 +39,7 @@ class NSXPolicyL3VPN(object): """ def __init__(self): - required_args.add_argument('--remote-endpoint-public-ip', + required_args.add_argument('--remote_endpoint_public_ip', required=True, help='L3 VPN Remote end point\'s public ip') diff --git a/samples/vmc/networks_nsxt/security_group_create.py b/samples/vmc/networks_nsxt/security_group_create.py index 728b7aa7..dab65011 100644 --- a/samples/vmc/networks_nsxt/security_group_create.py +++ b/samples/vmc/networks_nsxt/security_group_create.py @@ -36,7 +36,7 @@ Create a new NSX-T Group on MGW or CGW Sample Prerequisites: - SDDC deployed in VMware Cloud on AWS """ -optional_args.add_argument('--gateway-type', +optional_args.add_argument('--gateway_type', default='mgw', help='Gateway type. Either mgw or cgw') @@ -44,11 +44,11 @@ required_args.add_argument('--name', required=True, help='Name of the security group to be created') -optional_args.add_argument('--ip-address', +optional_args.add_argument('--ip_address', default='172.31.0.0/24', help='IP address for the expression') -optional_args.add_argument('--group-id', +optional_args.add_argument('--group_id', help='ID of the group. A random ID will be used by default') args = parser.parse_args() diff --git a/samples/vmc/networks_nsxt/security_group_delete.py b/samples/vmc/networks_nsxt/security_group_delete.py index 45686a8a..2af72759 100644 --- a/samples/vmc/networks_nsxt/security_group_delete.py +++ b/samples/vmc/networks_nsxt/security_group_delete.py @@ -39,11 +39,11 @@ Sample Prerequisites: - SDDC deployed in VMware Cloud on AWS - A NSX-T security group """ -optional_args.add_argument('--gateway-type', +optional_args.add_argument('--gateway_type', default='mgw', help='Gateway type. Either mgw or cgw') -optional_args.add_argument('--group-id', +optional_args.add_argument('--group_id', help='ID of the group to be deleted') args = parser.parse_args() diff --git a/samples/vmc/networks_nsxt/security_group_update.py b/samples/vmc/networks_nsxt/security_group_update.py index 180ca983..945fb7f6 100644 --- a/samples/vmc/networks_nsxt/security_group_update.py +++ b/samples/vmc/networks_nsxt/security_group_update.py @@ -40,11 +40,11 @@ Sample Prerequisites: - SDDC deployed in VMware Cloud on AWS - A NSX-T security group """ -optional_args.add_argument('--gateway-type', +optional_args.add_argument('--gateway_type', default='mgw', help='Gateway type. Either mgw or cgw') -optional_args.add_argument('--group-id', +optional_args.add_argument('--group_id', help='ID of the group to be updated') required_args.add_argument('--name', diff --git a/samples/vmc/orgs/organization_operations.py b/samples/vmc/orgs/organization_operations.py index 912244c8..0c7e76a2 100644 --- a/samples/vmc/orgs/organization_operations.py +++ b/samples/vmc/orgs/organization_operations.py @@ -41,7 +41,7 @@ class OperationsOnOrganizations(object): required_args = parser.add_argument_group( 'required arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='VMware Cloud API refresh token') diff --git a/samples/vmc/sddc/sddc_crud.py b/samples/vmc/sddc/sddc_crud.py index d3fe181f..d7f3ad88 100644 --- a/samples/vmc/sddc/sddc_crud.py +++ b/samples/vmc/sddc/sddc_crud.py @@ -41,12 +41,12 @@ class CreateDeleteSDDC(object): 'optional arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='Refresh token obtained from CSP') required_args.add_argument( - '--org-id', + '--org_id', required=True, help='Organization identifier.') diff --git a/samples/vmc/tasks/cancel_task.py b/samples/vmc/tasks/cancel_task.py index df7103d7..3f551f9b 100644 --- a/samples/vmc/tasks/cancel_task.py +++ b/samples/vmc/tasks/cancel_task.py @@ -32,7 +32,7 @@ required_args = parser.add_argument_group( 'required arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='Refresh token obtained from CSP') diff --git a/samples/vmc/tasks/list_tasks.py b/samples/vmc/tasks/list_tasks.py index dcb73665..6546b4ae 100644 --- a/samples/vmc/tasks/list_tasks.py +++ b/samples/vmc/tasks/list_tasks.py @@ -34,7 +34,7 @@ required_args = parser.add_argument_group( 'required arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='Refresh token obtained from CSP') required_args.add_argument( diff --git a/samples/vmc/tasks/list_tasks_stg.py b/samples/vmc/tasks/list_tasks_stg.py index 9c0c619e..ea17d352 100644 --- a/samples/vmc/tasks/list_tasks_stg.py +++ b/samples/vmc/tasks/list_tasks_stg.py @@ -36,7 +36,7 @@ optional_args = parser.add_argument_group( 'optional arguments') required_args.add_argument( - '--refresh-token', + '--refresh_token', required=True, help='Refresh token obtained from CSP')