From 0a969fddb4bfc3e263797d6646fcc163b5c6e67c Mon Sep 17 00:00:00 2001
From: michael <michael@balsillie.net>
Date: Sun, 30 Oct 2022 22:18:55 +1300
Subject: [PATCH] correct libvirt xml

---
 ansible/roles/vm_deploy/tasks/deploy.yaml            | 1 -
 ansible/roles/vm_deploy/templates/vm_template.xml.j2 | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/ansible/roles/vm_deploy/tasks/deploy.yaml b/ansible/roles/vm_deploy/tasks/deploy.yaml
index 4186250..5673eeb 100644
--- a/ansible/roles/vm_deploy/tasks/deploy.yaml
+++ b/ansible/roles/vm_deploy/tasks/deploy.yaml
@@ -74,7 +74,6 @@
     community.libvirt.virt:
       command: define
       autostart: false
-      name: "{{ vm_name }}"
       xml: "{{ lookup('template', 'vm_template.xml.j2') }}"
 
   - name: start vm
diff --git a/ansible/roles/vm_deploy/templates/vm_template.xml.j2 b/ansible/roles/vm_deploy/templates/vm_template.xml.j2
index 4e420bd..682de3e 100644
--- a/ansible/roles/vm_deploy/templates/vm_template.xml.j2
+++ b/ansible/roles/vm_deploy/templates/vm_template.xml.j2
@@ -12,7 +12,7 @@
     <partition>/machine</partition>
   </resource>
   <os>
-    <type arch={{ vm_machine_arch }} machine={{ vm_machine_type }}>hvm</type>
+    <type arch='{{ vm_machine_arch }}' machine='{{ vm_machine_type }}'>hvm</type>
     <loader readonly='yes' secure='yes' type='pflash'>/usr/share/edk2-ovmf/x64/OVMF_CODE.secboot.fd</loader>
     <nvram template=/usr/share/edk2-ovmf/x64/OVMF_VARS.fd>{{ firmware_vhd_pool_dir }}/{{ vm_name }}_VARS.fd</nvram>
     <boot dev='hd'/>
@@ -24,7 +24,7 @@
     <smm state='on'/>
   </features>
   <cpu mode='host-passthrough' check='none' migratable='on'>
-    <topology sockets='1' dies='1' cores={{ vm_cpu_cores }} threads={{ vm_cpu_threads }}/>
+    <topology sockets='1' dies='1' cores='{{ vm_cpu_cores }}' threads='{{ vm_cpu_threads }}'/>
   </cpu>
   <clock offset='utc'>
     <timer name='rtc' tickpolicy='catchup'/>
@@ -65,7 +65,7 @@
     <controller type='sata' index='0'/>
     <controller type='virtio-serial' index='0'/>
     <interface type='bridge'>
-      <mac address={{ vm_mac_prefix }}{{ vm_number }}'/>
+      <mac address='{{ vm_mac_prefix }}{{ vm_number }}'/>
       <source bridge='{{ vm_bridge }}'/>
       <model type='virtio'/>
     </interface>